Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename swap functions to not conflict with OpenBSD's swap macros #6384

Merged
merged 1 commit into from
May 20, 2024
Merged

Rename swap functions to not conflict with OpenBSD's swap macros #6384

merged 1 commit into from
May 20, 2024

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented May 3, 2024

Resolves: #6357

Rename swap functions to not conflict with OpenBSD's swap macros

  • I signed CLA
  • The title of the pull request describes an issue it addresses
  • If changes are extensive, then there is a sequence of easily reviewable commits
  • Each commit's message describes its purpose and effects
  • There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

  • Each commit compiles and runs on my machine without known undesirable changes of behavior

@brad0
Copy link
Contributor Author

brad0 commented May 10, 2024

Ping.

@igorkorsukov
Copy link
Collaborator

Maybe better to add something like this:
Stk.h

#ifdef swap16
#undef swap16
#endif

@vsverchinsky
Copy link
Collaborator

Existing code-style suggests using lower camel-case naming convention, name like byteSwap* or similar will fit better

@brad0 brad0 force-pushed the libnyquist_swap_function branch from 97469b7 to b3ff44b Compare May 15, 2024 21:52
@brad0 brad0 force-pushed the libnyquist_swap_function branch from b3ff44b to 4df2d48 Compare May 17, 2024 17:58
@brad0
Copy link
Contributor Author

brad0 commented May 19, 2024

@vsverchinsky Ping.

@vsverchinsky vsverchinsky merged commit d881c57 into audacity:master May 20, 2024
10 of 11 checks passed
@vsverchinsky
Copy link
Collaborator

@brad0 Thank you!

@brad0 brad0 deleted the libnyquist_swap_function branch May 20, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LWinterberg LWinterberg LWinterberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audacity swap16/32/64 functions conflict with OpenBSD swap macros
4 participants
@brad0 @igorkorsukov @vsverchinsky @LWinterberg