Updated "What's new" dialog #6437
Conversation
vsverchinsky
force-pushed
the
i6365-whats-new-dialog-update
branch
from
0040698
to
ea29fe5
Compare
src/SplashDialog.cpp
Outdated
There was a problem hiding this comment.
I think the entire SplashDialog can get deleted. We now always show the new WhatsNewDialog. HAS_WHATS_NEW also doesn't need to be a flag anymore.
The SplashDialog does have functions to show you some paragraphs about alpha and beta versions - I don't think we need those anymore, as long as the WhatsNewDialog a) is enabled in alpha/beta builds and b) says it is an alpha/beta in the dialog.
There was a problem hiding this comment.
When compiling out of sources you need to explicitly define -DSHOW_WHATS_NEW_SECTION=Yes cmake variable to enable this new dialog. CI is configured to define that variable for us, but it's not the case when compiling out of sources. Linux distros maintainers likely compile Audacity with old-style SplashDialog without images and links to YouTube.
There was a problem hiding this comment.
Right. Let's set SHOW_WHATS_NEW_SECTION=Yes in the source by default then, and let maintainers explicitly opt out of it if they don't want it. And if they do opt out, let's just not show any startup screen.
vsverchinsky
force-pushed
the
i6365-whats-new-dialog-update
branch
from
ea29fe5
to
60290ff
Compare
There was a problem hiding this comment.
I don't see anything wrong code safety wise, but am less able to judge if visually and behaviorally this meets the requirements, so maybe let @LWinterberg double-check on that before moving on.
| s | ||
| << wxT("<body bgcolor=") << wxSystemSettings::GetColour(wxSYS_COLOUR_BTNFACE).GetAsString(wxC2S_HTML_SYNTAX) << wxT(">") | ||
| << wxT("<p><center>") | ||
| << wxT(R"(<p><a href=")") << WhatsNewURL << wxT(R"(">)") |
There was a problem hiding this comment.
Minor: since WhatsNewURL is only used here, it could be constexpred within this method.
src/WhatsNewDialog.cpp
Outdated
| const char* PluginsURL = ""; | ||
| const char* MuseHubURL = ""; | ||
|
|
There was a problem hiding this comment.
MusehubURL and PluginsURL are identical. rename instances of PluginsURL to MuseHubURL and set MuseHubURL "https://www.musehub.com"
src/WhatsNewDialog.cpp
Outdated
|
|
||
| WhatsNewDialog::WhatsNewDialog(wxWindow* parent, wxWindowID id) | ||
| : wxDialogWrapper(parent, id, XO("Welcome to Audacity!"), | ||
| wxDefaultPosition, wxSize(906, 580)) |
There was a problem hiding this comment.
this is a little mighty I found. Unless there's rendering differences between platforms, I found that a window height of 480 worked well with a 20px border.
before:
after:
There was a problem hiding this comment.
This is how it looks on my machine with 40 px border :/
There was a problem hiding this comment.
Ah, this is because of dpi scaling ...
src/WhatsNewDialog.cpp
Outdated
|
|
||
| S.StartHorizontalLay(wxEXPAND); | ||
| { | ||
| S.SetBorder(40); |
|
Oh also, while we wait for the strings: similar to #6446 we need to hide the musehub part of this on Linux because it's not available there. Might look something like this:
|
|
Strings approved |
vsverchinsky
force-pushed
the
i6365-whats-new-dialog-update
branch
from
60290ff
to
0bdfebc
Compare
|
@LWinterberg can you please check how it looks now for you? |
|
windows @ 100% @ 150%
@ 225% |
vsverchinsky
force-pushed
the
i6365-whats-new-dialog-update
branch
from
0bdfebc
to
5847dce
Compare
|
Squashed and rebased |
Resolves: #6365
Needs correct links and images.
Recommended: