This repository has been archived by the owner on Apr 2, 2023. It is now read-only.
Fix npm lint #25
Merged
Fix npm lint #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… proper functions according to changes in react. https://github.com/reactjs/react-codemod#rename-unsafe-lifecycles
…or version of eslint, enabled exceptions for cammelcase option for mandatory changes to funciton names to start with UNSAFE_
|
@zorro786 can you sanity check this when you get a chance? |
zorro786
reviewed
Jul 28, 2020
| "eslint-config-standard": "^10.2.1", | ||
| "eslint-config-standard-react": "^5.0.0", | ||
| "eslint-plugin-chai-friendly": "^0.4.0", | ||
| "eslint-plugin-import": "^2.21.2", | ||
| "eslint-plugin-node": "^5.1.1", | ||
| "eslint-plugin-promise": "^3.5.0", | ||
| "eslint-plugin-react": "^7.20.0", | ||
| "eslint-plugin-react": "7.20.3", |
There was a problem hiding this comment.
Is removing ^ intended? It will not affect the installation if there is no 4th version field.
There was a problem hiding this comment.
Yup, it's intended because otherwise it'll upgrade to 7.20.4 (next minor version) which is currently broken.
I decided to pin it to 7.20.3 to avoid issues: jsx-eslint/eslint-plugin-react#2728 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Testing Done: