Send Angular Version as part of auth0Client header #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
commented
May 31, 2022
| env: { | ||
| 'angular/core': VERSION.full | ||
| } | ||
| } as any, |
There was a problem hiding this comment.
Will need to drop this once auth0/auth0-spa-js#913 is merged
There was a problem hiding this comment.
Thanks. I forgot the fact that it will also need a release. So will hold of merging here.
There was a problem hiding this comment.
Or maybe we should merge as is for now. As it should work, and might be a bit weird to cut a release in SPA-JS only for this.
stevehobbsdev
approved these changes
Jun 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sends the version of Angular being used as part of the auth0Client.