Fix: Ambiguous argument type definition

[willvedd]

✏️ Changes

A routine Typescript upgrade from 4.7.4 to 4.8.2 has imposed stricter checks on argument type definitions. More specifically, forbidding "unused property renaming in destructuring binding in function types" as described in this Typescipt project PR.

This was tripping up CircleCI when running the E2E CLI tests during the Typescript compilation step. The errors looked something like this:

src/types.ts:46:20 - error TS2842: 'string' is an unused renaming of 'id'. Did you intend to use it as a type annotation?

46     deploy: ({ id: string }) => Promise<void>;
                      ~~~~~~

  src/types.ts:46:28
    46     deploy: ({ id: string }) => Promise<void>;
                                  ~
    We can only write a type for 'id' by adding a type for the entire parameter here.

src/types.ts:48:40 - error TS2842: 'string' is an unused renaming of 'trigger_id'. Did you intend to use it as a type annotation?

48     getTriggerBindings: ({ trigger_id: string }) => Promise<{ bindings: Asset[] }>;

For this project, it just means being a little more explicit with the argument definition.

🔗 References

• Related Typescript PR
• Deploy CLI TS Upgrade PR

🎯 Testing

No additional tests necessary. Typescript compiler succeeds now.

[codecov-commenter]

Codecov Report

Merging #640 (ded483f) into master (fb9453d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #640   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files         114      114           
  Lines        3315     3315           
  Branches      611      611           
=======================================
  Hits         2762     2762           
  Misses        323      323           
  Partials      230      230           

Impacted Files	Coverage Δ
src/types.ts	100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.