Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Adding proxy functionality for node module usage #885

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willvedd
Copy link
Contributor

🔧 Changes

Even when a proxy_url is passed-in to the Deploy when used as a node module, it does not get utilized properly. This is because the run function, the sole function responsible for setting-up the proxy, is not executed when the functions are used as a node module. This PR proposed to move the proxy configuration into the dump and deploy functions themselves so that a proxy can be used by either mode of operation.

📚 References

🔬 Testing

Added a placeholder E2E test for local testing. Not yet sure if this test can be run in CI for lack of dependency proxy server.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant