Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing captcha arg to signup functions #1419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mriccid
Copy link

@mriccid mriccid commented Mar 21, 2024

Changes

  • Add options.captcha arg to DBConnection.prototype.signup function
  • Add options.captcha arg to WebAuth.prototype.signup function

References

Redirect.prototype.signupAndLogin already has this arg and passes it through to DBConnection.prototype.signup which is how I discovered that this was supported. Seems like the underlying functions and backend supports this arg. I've copied the JSDoc from signupAndLogin to ensure consistency.

Testing

I'm unsure of how to add an automated test to ensure that this works, however I have tested it in a project and passing through options.captcha with a real captcha value worked with an Auth0 tenant with Bot Protection enabled.

Checklist

@frederikprijck
Copy link
Member

Thanks for the PR.

However, the property you send isn't documented on the corresponding API docs, so we shouldn't add it to the SDK as that could indicate it's not officially supported, or not recommended to be used.

That said, we can always check internally what the idea is behind this and see if this should be documented on the API docs. If that would be the case, we can merge this PR. If not, we will need to close it.

Will get back to this.

@mriccid
Copy link
Author

mriccid commented Mar 21, 2024

Thanks for the PR.

However, the property you send isn't documented on the corresponding API docs, so we shouldn't add it to the SDK as that could indicate it's not officially supported, or not recommended to be used.

That said, we can always check internally what the idea is behind this and see if this should be documented on the API docs. If that would be the case, we can merge this PR. If not, we will need to close it.

Will get back to this.

That's interesting. Makes sense, let me know @frederikprijck. Thanks for getting back to me.

For what it's worth, there's official documentation that refers to this captcha argument that I found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants