Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty string audience claim should be deserialized as empty string #663

Merged
merged 1 commit into from Jun 9, 2023
Merged

Empty string audience claim should be deserialized as empty string #663

merged 1 commit into from Jun 9, 2023

Conversation

jimmyjames
Copy link
Contributor

Changes

Fixes #662 - an empty audience string was being deserialized as an empty list, instead of a list with an empty string.

@jimmyjames jimmyjames requested a review from a team as a code owner June 2, 2023 01:58
@jimmyjames jimmyjames mentioned this pull request Jun 2, 2023
Closed
5 tasks
poovamraj
poovamraj approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@poovamraj poovamraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good if this is behaviour is what we would be going for

andrewrigas
andrewrigas approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@andrewrigas andrewrigas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmyjames jimmyjames merged commit d8fe9a2 into master Jun 9, 2023
10 checks passed
@jimmyjames jimmyjames deleted the aud-empty-string-fix branch June 9, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poovamraj poovamraj poovamraj approved these changes

@andrewrigas andrewrigas andrewrigas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aud with empty string returns empty List
3 participants
@jimmyjames @poovamraj @andrewrigas