Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react version #1135

Merged
merged 7 commits into from
Oct 9, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
// Place your settings in this file to overwrite default and user settings.
{
// Place your settings in this file to overwrite default and user settings.
"search.exclude": {
"**/node_modules": true,
"**/bower_components": true,
"**/lib": true,
"**/coverage": true
"**/coverage": true,
"**/examples": true
},
"editor.formatOnSave": true,
"prettier.printWidth": 100,
"prettier.singleQuote": true
}
}
4 changes: 2 additions & 2 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ module.exports = function(grunt) {
port: 3000,
https: true,
webpack: {
devtool: 'eval'
devtool: 'cheap-module-source-map'
}
},
design: {
Expand All @@ -92,7 +92,7 @@ module.exports = function(grunt) {
path: path.join(__dirname, 'build'),
filename: 'lock.design.js'
},
devtool: 'eval'
devtool: 'cheap-module-source-map'
}
}
},
Expand Down
20 changes: 10 additions & 10 deletions css/_transitions.styl
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@

/*Slide out*/

.slide-leave {
.slide-exit {
-webkit-transform: translate3d(0, 0, 0);
transform: translate3d(0, 0, 0);
}

.slide-leave.slide-leave-active {
.slide-exit.slide-exit-active {
-webkit-transform: translate3d(100%, 0, 0);
transform: translate3d(100%, 0, 0);
-webkit-transition: -webkit-transform .3s ease-in;
Expand Down Expand Up @@ -58,13 +58,13 @@

/*vslide out*/

.vslide-leave {
.vslide-exit {
-webkit-transform: translate3d(0, 0, 0);
transform: translate3d(0, 0, 0);
}


.vslide-leave.vslide-leave-active {
.vslide-exit.vslide-exit-active {
-webkit-transform: translate3d(0, 100%, 0);
transform: translate3d(0, 100%, 0);
-webkit-transition: -webkit-transform .35s;
Expand Down Expand Up @@ -93,15 +93,15 @@

/*Horizontal fade out*/

.horizontal-fade-leave {
.horizontal-fade-exit {
opacity: 1;
position: absolute;
width: 100%;
top: 0;
left: 0;
}

.horizontal-fade-leave.horizontal-fade-leave-active {
.horizontal-fade-exit.horizontal-fade-exit-active {
opacity: 0;
-webkit-transform: translate3d(-100%, 0, 0);
transform: translate3d(-100%, 0, 0);
Expand Down Expand Up @@ -132,15 +132,15 @@

/* reverse horizontal fade out */

.reverse-horizontal-fade-leave {
.reverse-horizontal-fade-exit {
opacity: 1;
position: absolute;
width: 100%;
top: 0;
left: 0;
}

.reverse-horizontal-fade-leave.reverse-horizontal-fade-leave-active {
.reverse-horizontal-fade-exit.reverse-horizontal-fade-exit-active {
opacity: 0;
-webkit-transform: translate3d(100%, 0, 0);
transform: translate3d(100%, 0, 0);
Expand All @@ -163,7 +163,7 @@

/* fade out*/

.fade-leave {
.fade-exit {
opacity: 1;
position: absolute;
width: 100%;
Expand All @@ -173,7 +173,7 @@
opacity: 1;
}

.fade-leave.fade-leave-active {
.fade-exit.fade-exit-active {
opacity: 0;

-webkit-transition: opacity .5s linear;
Expand Down
4 changes: 2 additions & 2 deletions css/index.styl
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ tabsHeight = 40px
paddingTop 10px
paddingBottom 10px

&.global-message-leave
&.global-message-exit
transition all 0.2s
height 0
paddingTop 0
Expand Down Expand Up @@ -132,7 +132,7 @@ tabsHeight = 40px
background white
position relative

&.horizontal-fade-leave
&.horizontal-fade-exit
.auth0-lock-content, .auth0-lock-terms
opacity .3
pointer-events none
Expand Down
60 changes: 24 additions & 36 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,7 @@
"description": "Auth0 Lock",
"author": "Auth0 <support@auth0.com> (http://auth0.com)",
"license": "MIT",
"keywords": [
"auth0",
"auth",
"openid",
"authentication",
"passwordless",
"browser",
"jwt"
],
"keywords": ["auth0", "auth", "openid", "authentication", "passwordless", "browser", "jwt"],
"repository": {
"type": "git",
"url": "git://github.com/auth0/lock"
Expand All @@ -28,10 +20,13 @@
"precommit": "lint-staged",
"lint": "eslint --ext .jsx,.js src/",
"test": "cross-env BABEL_ENV=test zuul -- test/**/*.test.js",
"test:browser": "cross-env BABEL_ENV=test zuul --local 8080 --disable-tunnel -- test/**/*.test.js",
"test:cli": "cross-env BABEL_ENV=test mochify --extension=.jsx --transform=babelify test/**/*.test.js",
"test:watch": "cross-env BABEL_ENV=test mochify --watch --extension=.jsx --transform=babelify test/**/*.test.js",
"test:jest": "jest --coverage",
"test:browser":
"cross-env BABEL_ENV=test zuul --local 8080 --disable-tunnel -- test/**/*.test.js",
"test:cli":
"cross-env BABEL_ENV=test mochify --extension=.jsx --transform=babelify ./test/setup.js test/**/*.test.js",
"test:watch":
"cross-env BABEL_ENV=test mochify --watch --extension=.jsx --transform=babelify ./test/setup.js test/**/*.test.js",
"test:jest": "jest --coverage --runInBand",
"test:jest:watch": "jest --watch --coverage",
"publish:cdn": "ccu",
"release": "scripts/release.sh",
Expand All @@ -45,15 +40,16 @@
"babel-plugin-transform-css-import-to-string": "0.0.2",
"babel-plugin-version-inline": "^1.0.0",
"babel-preset-es2015": "^6.22.0",
"babel-preset-react": "^6.16.0",
"babel-preset-react": "^6.24.1",
"babel-preset-stage-0": "^6.3.13",
"babelify": "^7.2.0",
"bump-version": "^0.5.0",
"component-cdn-uploader": "auth0/component-cdn-uploader#v1.3.0",
"cross-env": "^3.1.4",
"css-loader": "^0.26.1",
"dotenv": "^4.0.0",
"enzyme": "2.7.0",
"enzyme": "^3.1.0",
"enzyme-adapter-react-16": "^1.0.1",
"eslint": "^3.19.0",
"eslint-config-prettier": "^1.7.0",
"eslint-plugin-react": "^6.10.3",
Expand All @@ -68,14 +64,13 @@
"grunt-exec": "^0.4.6",
"grunt-webpack": "^2.0.1",
"husky": "^0.13.3",
"jest": "19.0.0",
"jest": "^21.2.1",
"json-beautify": "^1.0.1",
"jsonwebtoken": "^7.3.0",
"lint-staged": "^3.4.0",
"mochify": "^2.12.0",
"mochify": "^3.3.0",
"prettier": "^1.2.2",
"react-addons-test-utils": "^15.6.0",
"react-test-renderer": "^15.6.1",
"react-test-renderer": "^16.0.0",
"semver": "^5.3.0",
"sinon": "^1.15.4",
"stylus": "^0.54.5",
Expand All @@ -98,10 +93,10 @@
"immutable": "^3.7.3",
"jsonp": "^0.2.0",
"password-sheriff": "^1.1.0",
"prop-types": "^15.5.10",
"prop-types": "^15.6.0",
"react": "^15.6.1 || ^16.0.0",
"react-dom": "^15.6.1 || ^16.0.0",
"react-transition-group": "^1.2.0",
"react-transition-group": "^2.2.1",
"superagent": "^3.3.1",
"trim": "0.0.1",
"url-join": "^1.1.0"
Expand All @@ -114,32 +109,25 @@
"localPath": "build"
},
"jest": {
"modulePaths": [
"<rootDir>/src/",
"<rootDir>/src/__tests__"
],
"modulePaths": ["<rootDir>/src/", "<rootDir>/src/__tests__"],
"setupFiles": ["<rootDir>/src/__tests__/setup-tests.js"],
"coveragePathIgnorePatterns": [
"/node_modules/",
"<rootDir>/test/",
"<rootDir>/lib/",
"<rootDir>/src/__tests__/testUtils.js"
"<rootDir>/src/__tests__/testUtils.js",
"<rootDir>/src/__tests__/setup-tests.js"
],
"testPathIgnorePatterns": [
"/node_modules/",
"<rootDir>/test/",
"<rootDir>/lib/",
"<rootDir>/src/__tests__/testUtils.js"
"<rootDir>/src/__tests__/testUtils.js",
"<rootDir>/src/__tests__/setup-tests.js"
],
"coverageReporters": [
"lcov",
"text-summary"
]
"coverageReporters": ["lcov", "text-summary"]
},
"lint-staged": {
"*.{js,jsx}": [
"npm run lint",
"prettier --write --print-width 100 --single-quote",
"git add"
]
"*.{js,jsx}": ["npm run lint", "prettier --write --print-width 100 --single-quote", "git add"]
}
}
4 changes: 2 additions & 2 deletions src/__tests__/core/__snapshots__/index.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ exports[`setResolvedConnection sets the connection 1`] = `
Array [
"m",
"resolvedConnection",
Object {
"name": "bar",
Immutable.Map {
"type": "database",
"name": "bar",
},
]
`;
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/field/__snapshots__/username.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Object {

exports[`field/username setUsername() calls setField 1`] = `
Array [
Object {
Immutable.Map {
"validation": null,
},
"username",
Expand Down
12 changes: 12 additions & 0 deletions src/__tests__/setup-tests.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// setup file
import { configure } from 'enzyme';
import Adapter from 'enzyme-adapter-react-16';

jest.mock('react-dom/node_modules/fbjs/lib/warning');

configure({ adapter: new Adapter() });

//jest polyfills
global.requestAnimationFrame = function(callback) {
setTimeout(callback, 0);
};
8 changes: 4 additions & 4 deletions src/__tests__/ui/box/global_message.test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ describe('GlobalMessage', () => {
wrapper.getDOMNode().getBoundingClientRect = getBoundingClientRectSpy;
wrapper.getDOMNode().scrollIntoView = scrollIntoViewSpy;

wrapper.getNode().componentDidMount();
wrapper.instance().componentDidMount();

expect(getBoundingClientRectSpy).toHaveBeenCalled();
expect(scrollIntoViewSpy).toHaveBeenCalledWith(true);
Expand All @@ -31,7 +31,7 @@ describe('GlobalMessage', () => {
wrapper.getDOMNode().getBoundingClientRect = getBoundingClientRectSpy;
wrapper.getDOMNode().scrollIntoView = scrollIntoViewSpy;

wrapper.getNode().componentDidMount();
wrapper.instance().componentDidMount();

expect(getBoundingClientRectSpy).toHaveBeenCalled();
expect(scrollIntoViewSpy).not.toHaveBeenCalled();
Expand All @@ -43,7 +43,7 @@ describe('GlobalMessage', () => {
wrapper.getDOMNode().getBoundingClientRect = getBoundingClientRectSpy;
wrapper.getDOMNode().scrollIntoView = scrollIntoViewSpy;

wrapper.getNode().componentDidMount();
wrapper.instance().componentDidMount();

expect(getBoundingClientRectSpy).toHaveBeenCalled();
expect(scrollIntoViewSpy).toHaveBeenCalledWith(true);
Expand All @@ -55,7 +55,7 @@ describe('GlobalMessage', () => {
wrapper.getDOMNode().getBoundingClientRect = getBoundingClientRectSpy;
wrapper.getDOMNode().scrollIntoView = scrollIntoViewSpy;

wrapper.getNode().componentDidMount();
wrapper.instance().componentDidMount();

expect(scrollIntoViewSpy).not.toHaveBeenCalled();
});
Expand Down
2 changes: 1 addition & 1 deletion src/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export default class Base extends EventEmitter {
tabs: screen.renderTabs(m),
terms: screen.renderTerms(m, i18nProp.html('signUpTerms')),
title: getScreenTitle(m),
transitionName: screen.name === 'loading' ? 'fade' : 'horizontal-fade',
classNames: screen.name === 'loading' ? 'fade' : 'horizontal-fade',
scrollGlobalMessagesIntoView: l.ui.scrollGlobalMessagesIntoView(m)
};
render(l.ui.containerID(m), props);
Expand Down