Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bugs in the EXAMPLES.md's code snippets #994

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed bugs in the EXAMPLES.md's code snippets #994

wants to merge 2 commits into from

Conversation

grjan7
Copy link

@grjan7 grjan7 commented Mar 23, 2024

Changes

  • Updated the request options as per the src.
  • Fixed incorrect object reference.

References

The source files.

Testing

Please check the relevant objects in the /src.

Checklist

@grjan7 grjan7 requested a review from a team as a code owner March 23, 2024 12:13
frederikprijck
frederikprijck requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@frederikprijck frederikprijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, the majority looks realy good 🔥 , just left one comment.

EXAMPLES.md Outdated Show resolved Hide resolved
@grjan7
Copy link
Author

grjan7 commented Mar 25, 2024

Thanks for the changes, the majority looks realy good 🔥 , just left one comment.

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck Awaiting requested review from frederikprijck

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grjan7 @frederikprijck