Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for express-jwt@7 #297

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

jfromaniello
Copy link
Member

Description

I changed the signature of express-jwt in version 7. This change makes node-jwks-rsa compatible with v6 and v7.

References

auth0/express-jwt#281

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@jfromaniello
Copy link
Member Author

This address issue #296

package.json Outdated
@@ -14,6 +14,7 @@
"dependencies": {
"@types/express-jwt": "0.0.42",
"debug": "^4.3.4",
"express-jwt-v7": "npm:express-jwt@^7.5.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in devDependencies

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! fixed

@adamjmcgrath adamjmcgrath merged commit f43bea1 into auth0:master Apr 26, 2022
@adamjmcgrath
Copy link
Contributor

Thanks @jfromaniello! Will publish a release shortly

@jfromaniello jfromaniello deleted the express_jwt_7 branch April 26, 2022 14:21
@jfromaniello
Copy link
Member Author

awesome!

@adamjmcgrath adamjmcgrath mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants