Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize dashes in JWT permissions/scopes #184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkilmanas
Copy link
Contributor

Changes

When converting permissions/scopes to Symfony roles, apply replacement not only for colon (:) character, but also for dash (-) character, as some resources/permissions consist of multiple words and dash is a recommended separator in such cases.

Testing

  • Have a permission/scope in Auth0 token that contains a dash (e.g. read:licence-plates)
  • Convert it to Symfony roles (by getting the roles of the JWT authenticated user/m2m):
    • before: it would return ROLE_READ_LICENCE-PLATES
    • after: it returns ROLE_READ_LICENCE_PLATES

[ ] This change adds test coverage

[ ] This change has been tested on the latest version of Symfony

Checklist

[x] I have read the Auth0 general contribution guidelines

[x] I have read the Auth0 Code of Conduct

[x] All existing and new tests complete without errors

@evansims
Copy link
Member

Hey @mkilmanas thanks a lot for contributing this; our team is at an offsite this week so my bandwidth is a little limited, but I'll take a look at this as soon as I'm back at my desk next week. Appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants