Update recorder to skip saving 429 responses #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
commented
Oct 25, 2022
| i.Request.Host = strings.Replace(i.Request.Host, domain, RecordingsDomain, -1) | ||
| i.Request.URL = strings.Replace(i.Request.URL, domain, RecordingsDomain, -1) | ||
|
|
||
| i.Response.Duration = time.Millisecond |
There was a problem hiding this comment.
We don't really need to set the duration to 1ms as we already set SkipRequestLatency: true on the recorder options.
Codecov ReportBase: 86.74% // Head: 86.74% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
=======================================
Coverage 86.74% 86.74%
=======================================
Files 41 41
Lines 8730 8730
=======================================
Hits 7573 7573
Misses 890 890
Partials 267 267 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sergiught
force-pushed
the
patch/go-vcr-bump-skip-429
branch
from
00f675e
to
c937bc8
Compare
willvedd
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
In this PR we're testing out the changes introduced within the go-vcr pkg that allow us to skip saving on disk certain interactions like 429s.
📚 References
🔬 Testing
📝 Checklist