Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate Password Strength (Entropy) #143

Open
hpoul opened this issue Sep 14, 2020 · 9 comments · May be fixed by #241
Open

Calculate Password Strength (Entropy) #143

hpoul opened this issue Sep 14, 2020 · 9 comments · May be fixed by #241
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@hpoul
Copy link
Collaborator

hpoul commented Sep 14, 2020 •
edited

Password Generator: could display the entropy, should be pretty straight forward: https://en.wikipedia.org/wiki/Password_strength#Random_passwords
@hpoul hpoul added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 14, 2020
hpoul added a commit that referenced this issue Sep 14, 2020
@hpoul
File Create: Show password strength #143
6beafb2
@priyanshu0405
Copy link

Hey @hpoul, can I take this issue? Thanks!!

@hpoul
Copy link
Collaborator Author

hpoul commented Sep 26, 2020

@priyanshu0405 for sure, would be a amazing! Let me know if there is anything I can help you with ;)

@monkaushik10
Copy link

Hi, can I work on this issue?

@hpoul
Copy link
Collaborator Author

hpoul commented Oct 29, 2020

@priyanshu0405 are you still working on this issue?

@aryanA101a
Copy link

@hpoul I have pulled request for this issue. There is some problem with the check. Can you please help me with that?

@ilius
Copy link

ilius commented Jan 22, 2021 •
edited

PR doesn't look right to me.

It's a simple math formula: log2(charSetSize ^ passLength) which is equal to passLength * log2(charSetSizd).
I think the second fomula is better because you loose less accuracy in the limited float space.

Both passLength and charSetSize depend on user input, so entropy should be calculated on user input (Length change, or check/uncheck a character group)

@arshiamoghimi arshiamoghimi linked a pull request Jul 15, 2021 that will close this issue
Open
@ddjerqq
Copy link

ddjerqq commented Jan 21, 2024

is this issue still relevant?

@ilius
Copy link

ilius commented Jan 21, 2024

Can't see why not.

@ddjerqq
Copy link

ddjerqq commented Jan 21, 2024

last activity on the PR was 2 years ago

@ngthailam ngthailam mentioned this issue Feb 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

password strength display implemented arshiamoghimi/authpass
6 participants
@ilius @hpoul @aryanA101a @ddjerqq @priyanshu0405 @monkaushik10