Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password strength display implemented #241

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arshiamoghimi
Copy link

It adds password strength display to entry details. Fixes #143

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Hamedamz
❌ Arshia Moghimi


Arshia Moghimi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@hpoul hpoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution - #143 is actually about showing the password strength (and entropy) if the password generator, not in the entry details. but i'd be fine with this as well..
but then it should be coupled with the password field.. (there can be multiple) and there shouldn't be any static state/variables. I hope that makes sense.

Comment on lines +277 to +281
static Result? _strength;

static void _set_strength(Result? result) {
_strength = result;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong.. never use static variables for state. There has to be a better way for communicating with the child widget.

I also don't quite understand it, as there can be multiple passwords in one entry.. which one will this show the strength of? is not really obvious to me. I think this should all be encapsulated in the password field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculate Password Strength (Entropy)
4 participants