New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
password strength display implemented #241
base: main
Are you sure you want to change the base?
password strength display implemented #241
Conversation
Arshia Moghimi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution - #143 is actually about showing the password strength (and entropy) if the password generator, not in the entry details. but i'd be fine with this as well..
but then it should be coupled with the password field.. (there can be multiple) and there shouldn't be any static state/variables. I hope that makes sense.
static Result? _strength; | ||
|
||
static void _set_strength(Result? result) { | ||
_strength = result; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong.. never use static variables for state. There has to be a better way for communicating with the child widget.
I also don't quite understand it, as there can be multiple passwords in one entry.. which one will this show the strength of? is not really obvious to me. I think this should all be encapsulated in the password field.
07309c0
to
be49e16
Compare
It adds password strength display to entry details. Fixes #143