Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Feature: Password Entropy #207

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aryanA101a
Copy link

No description provided.

@ilius
Copy link

ilius commented Jan 22, 2021

Looks like you are using a hardcoded set/number of characters!
Entropy should be calculated based the number of possible characters that the user has selected/checked.
And you don't need Regex for that.
It's a simple math formula: log2(charSetSize ^ passLength)
Both these numbers depend on user input, so entropy should be calculated on user input (Length change, or check/uncheck a character group)

@hpoul
Copy link
Collaborator

hpoul commented Jan 24, 2021

@ilius do you think you could fix this implementation with your suggestion? 😅️

p.s. sorry for the late response to this PR, been a bit busy in the last few months

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants