Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update renovate.json #466

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Update renovate.json #466

merged 1 commit into from
Mar 7, 2022

Conversation

ecordell
Copy link
Contributor

@ecordell ecordell commented Mar 7, 2022

The error in #463 appears to be due to the gomodUpdateImportPaths which runs https://github.com/marwan-at-work/mod

Locally, I tested by taking the command from the PR:

sudo docker run --platform=linux/amd64 --rm --name=renovate_go --label=renovate_child -v "$(pwd)":"/mnt/renovate/gh/authzed/spicedb" -v "/tmp/renovate-cache":"/tmp/renovate-cache" -e GOPATH -e GOPROXY -e GOFLAGS -e CGO_ENABLED -e GIT_CONFIG_KEY_0 -e GIT_CONFIG_VALUE_0 -e GIT_CONFIG_KEY_1 -e GIT_CONFIG_VALUE_1 -e GIT_CONFIG_KEY_2 -e GIT_CONFIG_VALUE_2 -e GIT_CONFIG_COUNT -e GIT_CONFIG_KEY_3 -e GIT_CONFIG_VALUE_3 -e GIT_CONFIG_KEY_4 -e GIT_CONFIG_VALUE_4 -e GIT_CONFIG_KEY_5 -e GIT_CONFIG_VALUE_5 -w "/mnt/renovate/gh/authzed/spicedb/e2e" docker.io/renovate/go:1.17.8 bash -l -c "go get -d -t ./... && go install github.com/marwan-at-work/mod/cmd/mod@latest && mod upgrade --mod-name=github.com/authzed/spicedb -t=3 && mod upgrade --mod-name=github.com/brianvoe/gofakeit/v6 -t=3 && go mod tidy && go mod tidy"

and removing the mod commands:

sudo docker run --platform=linux/amd64 --rm --name=renovate_go --label=renovate_child -v "$(pwd)":"/mnt/renovate/gh/authzed/spicedb" -v "/tmp/renovate-cache":"/tmp/renovate-cache" -e GOPATH -e GOPROXY -e GOFLAGS -e CGO_ENABLED -e GIT_CONFIG_KEY_0 -e GIT_CONFIG_VALUE_0 -e GIT_CONFIG_KEY_1 -e GIT_CONFIG_VALUE_1 -e GIT_CONFIG_KEY_2 -e GIT_CONFIG_VALUE_2 -e GIT_CONFIG_COUNT -e GIT_CONFIG_KEY_3 -e GIT_CONFIG_VALUE_3 -e GIT_CONFIG_KEY_4 -e GIT_CONFIG_VALUE_4 -e GIT_CONFIG_KEY_5 -e GIT_CONFIG_VALUE_5 -w "/mnt/renovate/gh/authzed/spicedb/e2e" docker.io/renovate/go:1.17.8 bash -l -c "go get -d -t ./... && go mod tidy"

The first command failed with the same error as the PR, the second one passed. so 馃 this will fix renovate

@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Mar 7, 2022
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell merged commit c774d2d into main Mar 7, 2022
@ecordell ecordell deleted the renovate-go branch March 7, 2022 15:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants