add prefixes to lookup metrics #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
force-pushed
the
tenant-label-metric
branch
from
64e6dd6
to
6499483
Compare
github-actions
bot
added
the
area/tooling
jakedt
requested changes
Mar 11, 2022
| return ld.lookupHandler.LookupViaChecks(ctx, validatedReq) | ||
| } | ||
|
|
||
| return ld.lookupHandler.Lookup(ctx, validatedReq) | ||
| } | ||
|
|
||
| func prefix(namespace string) (prefix string) { |
There was a problem hiding this comment.
We must have some code for this somewhere...
There was a problem hiding this comment.
I didn't see anything that assumed the namespace string had already been validated like it is here
internal/dispatch/graph/graph.go
Outdated
| return ld.lookupHandler.LookupViaChecks(ctx, validatedReq) | ||
| } | ||
|
|
||
| return ld.lookupHandler.Lookup(ctx, validatedReq) | ||
| } | ||
|
|
||
| func prefix(namespace string) (prefix string) { | ||
| parts := strings.Split(namespace, "/") |
ecordell
force-pushed
the
tenant-label-metric
branch
from
6499483
to
5b24dce
Compare
jakedt
approved these changes
Mar 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.