protect prom metric registration with a lock #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be a good place for sync.Once |
jzelinskie
reviewed
Mar 16, 2022
Comment on lines
+373
to
+376
| promOnce.Do(func() { | ||
| grpcprom.EnableHandlingTimeHistogram(grpcprom.WithHistogramBuckets( | ||
| []float64{.006, .010, .018, .024, .032, .042, .056, .075, .100, .178, .316, .562, 1.000}, | ||
| )) | ||
| }) |
There was a problem hiding this comment.
I think it's more confusing to not just inline this, rather than putting it in a function.
pkg/cmd/server/server.go
Outdated
|
|
||
| var promOnce sync.Once | ||
|
|
||
| // enableGRPCHistogram protects prom metric registration with a sync.Once. |
There was a problem hiding this comment.
I'd say something like: enableGRPCHistogram enables the standard time history for gRPC requests, ensuring that it is only enabled once
instead of making it a global
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of making it a global