Add additional error context onto schema errors #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v0
josephschorr
force-pushed
the
error-context
branch
from
5e3b2eb
to
0017068
Compare
samkim
reviewed
Mar 18, 2022
| @@ -130,18 +130,18 @@ func TestEditCheck(t *testing.T) { | |||
|
|
|||
| definition resource { | |||
| relation writer: user | |||
| permission writer = writer | |||
| permission writer = writer | |||
There was a problem hiding this comment.
Was actually done on purpose to give a different column index on the error message, but I adjusted to make less odd looking as bit
josephschorr
force-pushed
the
error-context
branch
2 times, most recently
from
feb47d1
to
3e22b63
Compare
samkim
reviewed
Mar 23, 2022
pkg/commonerrors/common.go
Outdated
| } | ||
|
|
||
| // NewErrorWithSource creates and returns a new ErrorWithSource. | ||
| func NewErrorWithSource(err error, sourceCodeString string, lineNumber uint64, columnPosition uint64) *ErrorWithSource { |
There was a problem hiding this comment.
Note in method doc or change line number and column position param names to include that they are 1-based to make it clear to the caller? All other line/col fields are named and/or documented so might as well for this as well.
josephschorr
force-pushed
the
error-context
branch
from
3e22b63
to
bedfc14
Compare
|
Updated |
josephschorr
force-pushed
the
error-context
branch
from
bedfc14
to
849546d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds source position information onto the compiled namespace definitions and then uses it in the type system to return errors with more context
Fixes #447 and Fixes AUTHZ-422