Fix handling of REST gateway options and add an integration test #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/CLI
josephschorr
force-pushed
the
fix-restgateway
branch
from
f193fe3
to
a9fb7ec
Compare
ecordell
reviewed
Mar 22, 2022
Comment on lines
+244
to
+247
| if c.HTTPGateway.Enabled { | ||
| log.Info().Str("upstream", c.HTTPGatewayUpstreamAddr).Msg("starting REST gateway") | ||
| } | ||
|
|
There was a problem hiding this comment.
this logging is already covered by the httpserver object (and is misleading anyway - it doesn't start running here, it starts running down in Run)
{"level":"warn","addr":":8443","prefix":"http","time":"2022-03-22T13:30:05Z","message":"http server serving plaintext"}
There was a problem hiding this comment.
But it doesn't show the upstream address, which was the issue in the first place
Co-authored-by: Evan Cordell <cordell.evan@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.