Add support for nil in schema
#494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v0
jakedt
requested changes
Mar 22, 2022
internal/graph/check.go
Outdated
| case *core.SetOperation_Child_XNil: | ||
| requests = append(requests, notMember()) | ||
| default: | ||
| return checkError(errors.New("unknown set operation child in check")) |
There was a problem hiding this comment.
Can you get the operation name in the error somehow? All errors should have some data that helps debug it.
There was a problem hiding this comment.
Yeah, I wasn't sure what to print out before, but %T seems to provide sufficient info without being too verbose
pkg/namespace/builder.go
Outdated
| @@ -127,12 +127,20 @@ func setOperation(firstChild *core.SetOperation_Child, rest []*core.SetOperation | |||
| } | |||
|
|
|||
| // This creates a child for a set operation that references only direct usersets with the parent relation. | |||
| // DEPRECATED | |||
There was a problem hiding this comment.
Deprecated:? https://go.dev/blog/godoc
There was a problem hiding this comment.
Changed to a TODO to remove, otherwise it breaks lint
A `nil` expression under a permission is considered an empty set, and returns no permission
jakedt
approved these changes
Mar 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
nilexpression under a permission is considered an empty set, and returns no permission