Add integration testing for the migrate command #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/CLI
josephschorr
force-pushed
the
migrate-test
branch
from
b382b7f
to
a6ba611
Compare
ecordell
reviewed
Apr 22, 2022
Comment on lines
11
to
12
| // InitFunc initialize a datastore instance from a uri that has been | ||
| // generated from a TestDatastoreBuilder |
There was a problem hiding this comment.
Suggested change
| // InitFunc initialize a datastore instance from a uri that has been | |
| // generated from a TestDatastoreBuilder | |
| // InitFunc initializes a datastore instance from a uri that has been | |
| // generated from a RunningEngineForTest |
| // ExternalEnvVars are the environment variables to be set. | ||
| ExternalEnvVars() []string | ||
| } | ||
|
|
||
| // TestDatastoreBuilderFunc allows a function to implement TestDatastoreBuilder | ||
| type TestDatastoreBuilderFunc func(t testing.TB, initFunc InitFunc) datastore.Datastore |
There was a problem hiding this comment.
I would rename these too to match
| @@ -64,6 +66,10 @@ var ( | |||
| sb = sq.StatementBuilder.PlaceholderFormat(sq.Question) | |||
| ) | |||
|
|
|||
| func init() { | |||
| datastore.Engines = append(datastore.Engines, Engine) | |||
josephschorr
force-pushed
the
migrate-test
branch
from
a6ba611
to
1ea1a4b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs each datastore's backing engine or service in a container, and then creates another container with SpiceDB to perform the migration