Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/telemetry: report go version, git commit #553

Merged
merged 2 commits into from
Apr 25, 2022
Merged

internal/telemetry: report go version, git commit #553

merged 2 commits into from
Apr 25, 2022

Conversation

jzelinskie
Copy link
Member

@jzelinskie jzelinskie commented Apr 21, 2022 •
edited

This improves the version command and reports the go version in telemetry.

When provided no ldflags:

~/C/a/i/spicedb ❯❯❯ go build ./cmd/spicedb
~/C/a/i/spicedb ❯❯❯ ./spicedb version
spicedb 9679839c2d9c-dirty

This uses the new build info in Go 1.18, but degrades gracefully.

@jzelinskie jzelinskie requested a review from a team as a code owner April 21, 2022 20:57
@github-actions github-actions bot added the area/dependencies Affects dependencies label Apr 21, 2022
ecordell
ecordell previously approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@ecordell ecordell left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but doesn't this make spicedb 1.18+ only? Do we need to update go.mod / dockerfiles?

@jzelinskie
Copy link
Member Author

Yeah, I thought the build settings were available in 1.17, but they aren't...
Looking into what else I can do before bumping the Go version.

@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Apr 22, 2022
@ecordell
Copy link
Contributor

@jzelinskie image build is still failing?

ecordell
ecordell approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzelinskie jzelinskie merged commit d95708c into authzed:main Apr 25, 2022
@jzelinskie jzelinskie deleted the telemetry-version branch April 25, 2022 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ecordell ecordell ecordell approved these changes

Assignees
No one assigned
Labels
area/dependencies Affects dependencies area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jzelinskie @ecordell