Dispatch tests and metrics flag #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
josephschorr
force-pushed
the
dispatch-tests
branch
2 times, most recently
from
d1c9359
to
30273cf
Compare
vroldanbet
reviewed
Apr 25, 2022
internal/datastore/mysql/options.go
Outdated
| connMaxIdleTime: defaultConnMaxIdleTime, | ||
| connMaxLifetime: defaultConnMaxLifetime, | ||
| splitAtUsersetCount: defaultUsersetBatchSize, | ||
| enablePrometheusStats: false, |
There was a problem hiding this comment.
nit: do we want to pull a constant just like every other option?
| // Prometheus metrics are enabled by default. | ||
| func EnablePrometheusStats() Option { | ||
| // Prometheus metrics are disabled by default. | ||
| func WithEnablePrometheusStats(enablePrometheusStats bool) Option { |
There was a problem hiding this comment.
naming nit: perhaps WithPrometheusStats would be easier to reason about?
There was a problem hiding this comment.
I vacillated back and forth on that, but I decided to be explicit
| @@ -104,6 +104,7 @@ func RegisterDatastoreFlags(cmd *cobra.Command, opts *Config) { | |||
| cmd.Flags().DurationVar(&opts.RequestHedgingInitialSlowValue, "datastore-request-hedging-initial-slow-value", 10*time.Millisecond, "initial value to use for slow datastore requests, before statistics have been collected") | |||
| cmd.Flags().Uint64Var(&opts.RequestHedgingMaxRequests, "datastore-request-hedging-max-requests", 1_000_000, "maximum number of historical requests to consider") | |||
| cmd.Flags().Float64Var(&opts.RequestHedgingQuantile, "datastore-request-hedging-quantile", 0.95, "quantile of historical datastore request time over which a request will be considered slow") | |||
| cmd.Flags().BoolVar(&opts.EnableDatastoreMetrics, "datastore-prometheus-metrics", true, "set to false to disabled prometheus metrics from the datastore") | |||
There was a problem hiding this comment.
this does not seem to align with the default in the individual stores? e.g. https://github.com/authzed/spicedb/pull/561/files#diff-1f9d83984c96749a94659b71f4b5b8366b0b98e11e71923100983d110cd7b3a3R50
There was a problem hiding this comment.
Correct. It should be enabled by default from the CLI, but disabled by default if you just instantiate the datastore directly
There was a problem hiding this comment.
got it, it's intentional 👍🏻
josephschorr
force-pushed
the
dispatch-tests
branch
2 times, most recently
from
3321b45
to
c379d14
Compare
vroldanbet
previously approved these changes
Apr 25, 2022
ecordell
force-pushed
the
dispatch-tests
branch
from
c379d14
to
69c1d6f
Compare
josephschorr
force-pushed
the
dispatch-tests
branch
from
69c1d6f
to
684f4a1
Compare
ecordell
previously approved these changes
Apr 25, 2022
|
josephschorr
force-pushed
the
dispatch-tests
branch
from
684f4a1
to
662b246
Compare
josephschorr
force-pushed
the
dispatch-tests
branch
from
662b246
to
12cb0d1
Compare
ecordell
approved these changes
Apr 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.