Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datastore-engine help text #569

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Fix datastore-engine help text #569

merged 1 commit into from
Apr 28, 2022

Conversation

bryanhuhta
Copy link
Contributor

The datastore-engine flag doesn't include MySQL as an option, even though it is legal to select. This PR adds it to the example list.

Also, instead of hard-coding all the possible datastores, I sorted the keys in BuilderForEngine and displayed them. This way, any new datastore will automatically get added to the options list and there won't be any accidental drift.

Before:

--datastore-engine string    type of datastore to initialize ("memory", "postgres", "cockroachdb", "spanner") (default "memory")

After:

--datastore-engine string    type of datastore to initialize ("cockroachdb", "memory", "mysql", "postgres", "spanner") (default "memory")

Signed-off-by: Bryan Huhta <bryanhuhta@github.com>
@bryanhuhta bryanhuhta requested a review from a team as a code owner April 28, 2022 00:13
@github-actions github-actions bot added the area/CLI Affects the command line label Apr 28, 2022
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephschorr josephschorr merged commit 02fcac7 into authzed:main Apr 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2022
@bryanhuhta bryanhuhta deleted the bryanhuhta/add-mysql-option branch April 28, 2022 00:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/CLI Affects the command line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants