Switch to using Engines for the engine parameter #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
reviewed
Apr 28, 2022
pkg/cmd/datastore/datastore.go
Outdated
Comment on lines
92
to
93
| engines := append([]string{}, datastore.Engines...) | ||
| sort.Strings(engines) // Sort for stability. |
There was a problem hiding this comment.
Suggested change
| engines := append([]string{}, datastore.Engines...) | |
| sort.Strings(engines) // Sort for stability. | |
| sort.Strings(datastore.Engines) // Sort for stability. |
I don't think we really care if the original list gets sorted?
There was a problem hiding this comment.
I'd rather not change it, as its defined to be "static", for lack of a better term.
josephschorr
force-pushed
the
engine-param
branch
from
bbd7229
to
35b2f30
Compare
|
@ecordell Updated |
josephschorr
force-pushed
the
engine-param
branch
from
35b2f30
to
f005c1a
Compare
bryanhuhta
reviewed
Apr 28, 2022
| @@ -13,6 +14,13 @@ import ( | |||
|
|
|||
| var Engines = []string{} | |||
|
|
|||
| // SortedEngineIDs returns the full set of engine IDs, sorted. | |||
| func SortedEngineIDs() []string { | |||
| engines := append([]string{}, Engines...) | |||
There was a problem hiding this comment.
This will drop the quotes around each engine. Previously it was
"memory", "postgres" ...
But now it will be
memory, postgres ...
Nothing blocking, but it will look different from other flags that list valid options.
josephschorr
force-pushed
the
engine-param
branch
from
f005c1a
to
5aeb1e8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.