addresses server panic when malformed authorization header is sent #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/tooling
vroldanbet
changed the title
internal/auth/presharedkey_test.go
Outdated
| "google.golang.org/grpc/metadata" | ||
| ) | ||
|
|
||
| func TestMultiplePresharedKeys(t *testing.T) { |
There was a problem hiding this comment.
Maybe use a table-driven test here?
| {"valid request with the second key", []string{"one", "two"}, true, "two", codes.OK}, | ||
| {"denied due to unknown key", []string{"one", "two"}, true, "three", codes.PermissionDenied}, | ||
| {"unauthenticated due to missing key", []string{"one", "two"}, true, "", codes.Unauthenticated}, | ||
| {"unauthenticated due to missing metadata", []string{"one", "two"}, false, "", codes.Unauthenticated}, |
There was a problem hiding this comment.
Add a test with sending a header, but an empty one?
josephschorr
force-pushed
the
fix-presharedkey-panic
branch
from
ff19a64
to
bc41842
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢馃徎 Good day good people of the land of authorization, a quick fix!
What
addresses a server panic when a request with a malformed authorization header is received
How
presharedkey.gofile, including one that reproduces the problemstatus.Errorfcall that panics