Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s: add dispatch enabled comment #575

Merged
merged 1 commit into from
May 2, 2022
Merged

k8s: add dispatch enabled comment #575

merged 1 commit into from
May 2, 2022

Conversation

jzelinskie
Copy link
Member

No description provided.

@jzelinskie jzelinskie requested a review from jakedt April 29, 2022 15:23
@jzelinskie jzelinskie requested a review from a team as a code owner April 29, 2022 15:23
vroldanbet
vroldanbet approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 it also took me a while to figure out that there was also a flag for this. Perhaps a potential improvement on the usability is using the value of UPSTREAM_ADDR as the enablement condition? If string is not empty -> enabled, disabled otherwise.

@jakedt jakedt enabled auto-merge April 29, 2022 16:02
@jzelinskie jzelinskie disabled auto-merge May 2, 2022 20:04
@jzelinskie jzelinskie merged commit 53f8741 into authzed:main May 2, 2022
@jzelinskie jzelinskie deleted the comment-dispatch-toggle branch May 2, 2022 20:04
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vroldanbet vroldanbet vroldanbet approved these changes

@jakedt jakedt Awaiting requested review from jakedt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jzelinskie @vroldanbet