fix(gtk): select cloned item #604
Conversation
| @@ -142,7 +143,7 @@ Bug fixes | |||
| - Both QT and GTK versions will reload hotkeys after a keymap change event. | |||
| - Fix locking issue | |||
| - Expose Alt_GR as a hotkey modifier on GTK. | |||
| - (GTK) Fixed GUI lock-up, if multiple script error notifications are posted in quick succession. The notifications are now rate-limited and won’t post more than one notification per second. Fixes issue #383 | |||
| - (GTK) Fixed GUI lock-up, if multiple script error notifications are posted in quick succession. The notifications are now rate-limited and won’t post more than one notification per second. Fixes issue #383 | |||
There was a problem hiding this comment.
Whitespace change. Ideally we wouldn't have trailing whitespace in the first place, but it is usually considered annoying to open PRs that change whitespace in areas that aren't related to your change.
(Only a small PR so doesn't make a big difference in this case, but keep it in mind. Editor tools sometimes do this automatically, so review your diffs)
There was a problem hiding this comment.
Ah dang it, this must have been introduced in the rebase. I can remove the change, so I will.
|
Thank you so much for the PR! Also, if you edit the PR description to add "fixes #585", when it gets merged it will automatically close the relevant issue on github! |
|
Thanks for explaining the commit workflow, I'll be sure to make these updates! |
|
While this stands on its own as a valid enhancement/fix, does the Qt front end also need attention? @nevarek Welcome to our dev community! We really appreciate your contributions. |
|
Looks like this isn't an issue in qt, just gtk |
|
@nevarek Any reason this didn't get finished? It appears to be a valuable fix that just needs cosmetic changes. |
I don't recall, sorry. |
|
@nevarek From your response, I assume you are no longer interested in completing this bug fix. I am going to ask another developer to take a look at this if you don't want to do it. Thanks again for this PR. (Please don't delete it because we haven't copied it yet, etc.) |
No description provided.