New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use xdo to send strings instead of xrecord (allows sending unicode) #610
Open
BlueDrink9
wants to merge
10
commits into
autokey:develop
Choose a base branch
from
BlueDrink9:xdo
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently does it above interface and the event loop, which means it isn't async and may be interfered with if queued events regrab keys
This reverts commit 3bba2c5. Doesn't actually seem to work when run from threads. Needs more work
Pakinay
approved these changes
Jan 12, 2022
Pakinay
suggested changes
Jan 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
อัพเดทระบบ
@BlueDrink9 Code Triage just landed me here. Can you and/or @sebastiansam55 take a look at this and see if it's still relevant - especially with respect to the new Wayland work? It looks like it was a big deal when it was new. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255, #514, #207, #424, #20, maybe others that are related to sending input.
May address issues with typing being too fast, or may exacerbate them. Who knows! But this typing system comes with a delay of its own, which may fix it for some people in the background.
Will definitely need a lot of testing, and is currently probably even more fragile than our usual system. But it works! Wow! We wondered if it could even be done!
Unsure whether it will be merged into develop proper in current form, but I'm gonna leave it alone for a while. It's burned me out a bit getting things to this state, and more fixes will require a fair bit of energy.