[trace] upgrade opentelemetry to v1.22.0 #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
the
dependencies
|
@bianyuanop now that |
|
Done |
StephenButtolph
previously approved these changes
Feb 22, 2024
dhrubabasu
approved these changes
Feb 22, 2024
StephenButtolph
dismissed
their stale review
forgot to check the grpc version
|
Upgraded grpc to v1.62.0 along with a |
StephenButtolph
approved these changes
Feb 22, 2024
|
Seems I have to sign all the commits to get merged. Is there any way on your side to merge without signing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
I'm now integrating celestia-da with hypervm created with hypersdk, where celestia-node has a otel dependency with version v1.22.0, which is not compatible with avalanchego‘s. To resolve this, I opened this PR. It's likely the new projects will have more probability to use more recent version of otel so this dependency conflicts will happen more often.
How this works
The
noOpTracerstruct change follows this otel issueHow this was tested
it was tested by
Then