x/simulator: plan using not created key returns an error

[najeal]

Closes #861

@iFrostizz using a key that has not been created will fail except for key endpoint (endpoint for key creation)

[iFrostizz]

Hey @najeal , I think that it's a very reasonable fix, thank you very much!
Do you want to write a test that shows that the error is returned when not interacting with the key endpoint and that the key was not registered and it is not anymore after registering the key ?
If you don't want, I can too! As you want :)

[najeal]

Thank for your answer !
I tried to make a unit test instead of creating one test over the CLI. I also wrapped a cleanup function (manageCleanup()) to reuse it in the test but the function has approximately the same name than cleanupFn.

I would also prefer to avoid initialize a VM but #796 is not yet merged

[iFrostizz]

Small nit, very nice work thanks a lot!

[iFrostizz]

It's much nicer being more explicit about the encoding, thanks!

[najeal]

go test was not compiling before using borsh.Serialize I think simulator go tests are not run by the CI.
Not sure to understander your comment. Are you just saying it is better right now, or are you asking to be more explicit? 😀

[iFrostizz]

It was a CI issue, some static checks were not done and it led me to think that go was inferring the type, it was an actual bug that was apparently ignored! I'm not asking you to change anything

[iFrostizz]

This is looking good to me, looking for an additional approval

[richardpringle]

@najeal, just need to update the branch and fix the lint-issue

[najeal]

@richardpringle lint is fixed and branch is up-to-date with main 👍