[chain] Remove execute success #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlawt
requested review from
samliok,
dboehm-avalabs,
richardpringle and
patrick-ogrady
as code owners
4 tasks
wlawt
force-pushed
the
multi-action-support
branch
from
395c79c
to
43d77e2
Compare
patrick-ogrady
force-pushed
the
remove-action-err
branch
from
322aa2d
to
3b54a02
Compare
patrick-ogrady
changed the title
patrick-ogrady
added a commit
that referenced
this pull request
May 22, 2024
* add generic * emap passes * eheap passes * fix tokenvm orderbook * intro ActionID * intro max actions * enforce max actions + loop thru statekeys * fix some tx errors * fix builder errors * fix processor errors * fix more tx errors * fix client rpc error * fix morpheus transfer action * fix more morpheus * morpheusVM compiles * fix mock gen * fix morpheus static lint * fix lint and function signatures * fix rpc GenerateTx * import chain into morpheus actions * more lints * marhsal unmarshal Actions * totalUnits fees.Add * fix invalid signature * fix some tx fees and packing bytes * check maxActions earlier * morpheus integration passes * make action.Execute use actionID * intro codec.ActionID * fix tokenvm * tokevnm integration errors * fix tokenvm integration error * tokenvm integration passes * create long ID * fix token-cli lint * fix token fauct and feed lint * introduce multiple result.Outputs and morpheus integration passes * tokenvm integration passes using multiple result.Outputs * increase maxActions for tokenvm to 2 * add multiple transfers in 1 tx * add create and mint multiple assets * add multiple trades * add failed fill order * address lints * add hrp param to LIDFromString * fix x/programs lint * getmaxactionspertx should be uint8 * update readme * self review * fix rust ci * make get action id a helper * move GetMaxActionsPerTx * add MaxOutputsPerAction * actions instead of action * do sponsorkeys after action iteration * add action idx and type to ErrActionNotActivated * dont override prev outputs in handleRevert * skip all if one action is failed, do fee comp at the end, refund once * introduce LIDLen * fix type alias * use PackLID * use codec.LIDLen * EstimateMaxUnits over all actions * revert is populated in last output of last action * fix action Size * fix LID to and from String * make EmptyAddress const more generic * if not successful error is last output in last action * add comments in transaction * fix mock gen * fix rust ci * [chain] fix result size (#889) * include r.Outputs size in calculation above * fix packing of Outputs for each Action * [chain] Remove execute success (#894) * remove err from Action * mock gen * add more TODOs * add context on why revert is better * add back error * cleanup interface * cleanup tx loop * update error marshaling * update transfer op * cleaning up access * finish tokenvm * update mocks * fix programs * update create order * cleanup cmd program * backend.go compiles * more cleanup * morpheusvm integration passing * fix tokenvm integration * add nolint * require lint --------- Co-authored-by: Patrick O'Grady <prohb125@gmail.com> * remove trailing enter * revert `codec.LID` (#920) * remove LID definition * remove optional packer * update cli * update heap * eheap + emap * making progress on morpheusvm * cleanup load test error * tokenvm actions * update token-cli * update token-feed + token-faucet * update token-wallet * more progress in tokenvm * update token storage * use id const * update programs * unit tests passing * remove consts form simulator * fix lint * pass integration tests * integration test passing * reduce size of digest * fix load test * e2e lint * reuse nodes * reuse nodes * fix lint * run gci * multi-action nits (#922) * add key validity check to Keys set * cleanup state key validity checking * reviewed chain/transaction * cli changes * add multi-send example to morpheus * cleanup tokenvm * remove heap casting * fix program execute * fix return * cleanup var names * unify error * update fetcher tests * remove unnecessary conversion * update programs code * update action batches section --------- Co-authored-by: Patrick O'Grady <prohb125@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
Actionreturns anerr, it is considered unsuccessful (not fatal).