Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Programs cleanup #917

Merged
merged 28 commits into from
May 21, 2024
Merged

Programs cleanup #917

merged 28 commits into from
May 21, 2024

Conversation

dboehm-avalabs
Copy link
Contributor

@dboehm-avalabs dboehm-avalabs commented May 17, 2024 •
edited

Adds

  • tests
  • fuel consumption on host functions
  • fix programid type of callprogramargs
  • Align Address length between rust and go

richardpringle
richardpringle requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@richardpringle richardpringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave it to you whether or not you want to address the nits, but I will request newlines at the end of the files.

(I'm also happy to add the newlines if you want haha)

.github/workflows/hypersdk-ci.yml Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
x/programs/rust/wasmlanche-sdk/src/program.rs Show resolved Hide resolved
x/programs/rust/wasmlanche-sdk/src/types.rs Outdated Show resolved Hide resolved
x/programs/rust/wasmlanche-sdk/tests/public_function.rs Outdated Show resolved Hide resolved
x/programs/v2/test/programs/call_program/src/lib.rs Show resolved Hide resolved
x/programs/v2/test/programs/return_complex_type/Cargo.toml Outdated Show resolved Hide resolved
x/programs/v2/test/programs/return_complex_type/src/lib.rs Outdated Show resolved Hide resolved
x/programs/v2/test/programs/simple/Cargo.toml Outdated Show resolved Hide resolved
x/programs/v2/test/util.go Show resolved Hide resolved
@dboehm-avalabs dboehm-avalabs changed the title [WIP] Programs cleanup Programs cleanup May 21, 2024
dboehm-avalabs and others added 3 commits May 21, 2024 11:02
@dboehm-avalabs @richardpringle
Update x/programs/rust/wasmlanche-sdk/src/types.rs
fea0ec4 
Co-authored-by: Richard Pringle <richard.pringle@avalabs.org>
Signed-off-by: David Boehm <91908103+dboehm-avalabs@users.noreply.github.com>
@dboehm-avalabs @richardpringle
Update x/programs/rust/wasmlanche-sdk/tests/public_function.rs
a9948a9 
Co-authored-by: Richard Pringle <richard.pringle@avalabs.org>
Signed-off-by: David Boehm <91908103+dboehm-avalabs@users.noreply.github.com>
@dboehm-avalabs
new lines
c58f8b0
@dboehm-avalabs dboehm-avalabs mentioned this pull request May 21, 2024
Merged
@dboehm-avalabs dboehm-avalabs enabled auto-merge (squash) May 21, 2024 15:24
richardpringle
richardpringle approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@richardpringle richardpringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dboehm-avalabs dboehm-avalabs merged commit bd74dab into main May 21, 2024
26 checks passed
@dboehm-avalabs dboehm-avalabs deleted the ProgramsCleanup branch May 22, 2024 18:53
@dboehm-avalabs dboehm-avalabs mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardpringle richardpringle richardpringle approved these changes

@samliok samliok Awaiting requested review from samliok

@patrick-ogrady patrick-ogrady Awaiting requested review from patrick-ogrady patrick-ogrady is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dboehm-avalabs @richardpringle