Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiline snapshot labels #2773

Merged
merged 2 commits into from Jun 19, 2021

Conversation

KillyMXI
Copy link
Contributor

Issue #2769

This PR only addresses the snapshot label formatting at the moment.
Changing the test title formatting has much bigger impact. I need more info there. Depending on how much bigger scope it gets it might be better to handle separately.

@novemberborn novemberborn marked this pull request as ready for review June 19, 2021 18:04
Copy link
Member

@novemberborn novemberborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a commit to fix up the tests, but other than that I think this is good to go!

@novemberborn novemberborn linked an issue Jun 19, 2021 that may be closed by this pull request
@novemberborn novemberborn merged commit 1d92b78 into avajs:main Jun 19, 2021
@KillyMXI
Copy link
Contributor Author

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiline snapshot label/message
2 participants