Normalize glob patterns with trailing slashes

[asaid-0]

Fixes #2781

[asaid-0]

@novemberborn could you please review this

[novemberborn]

@asaid-0 thanks for the PR, I may have a chance to look at this on the weekend.

[novemberborn]

@asaid-0 it's been a while since I've had to think about glob patterns and file paths. Why does this solution do the trick?

[novemberborn]

cwd needs to be an argument here. AVA determines the directory to which patterns are relevant and it may not be the CWD.

[asaid-0]

thank you for pointing this out, I see now I think we should receive the CWD as an argument in the normalizeGlobs here:

ava/lib/globs.js

Line 35 in dc93f37

export function normalizeGlobs({extensions, files: filePatterns, ignoredByWatcher: ignoredByWatcherPatterns, providers}) {

Then we pass it to normalizePatterns call in the same function.

Also i noticed this line in cli.js

ava/lib/cli.js

Line 396 in dc93f37

pattern: normalizePattern(path.relative(projectDir, path.resolve(process.cwd(), pattern))),

which using nearly the same function path.relative, but path.resolve is being used in the second parameter to get the absolute path

[novemberborn]

I don't think the helper function is all that useful, especially since it hides the critical path.relative() bit which is then called directly below.

[asaid-0]

@asaid-0 it's been a while since I've had to think about glob patterns and file paths. Why does this solution do the trick?

@novemberborn Thank you for your feedback, actually, I used this solution assuming that we should also solve the issue with such patterns tests//test1, tests/sub/../test2 not only the trailing slash tests/test/

if we need to just solve the trailing slash issue I wouldn't use path.relative()
what do you think?

[novemberborn]

Thank you for your feedback, actually, I used this solution assuming that we should also solve the issue with such patterns tests//test1, tests/sub/../test2 not only the trailing slash tests/test/

if we need to just solve the trailing slash issue I wouldn't use path.relative()
what do you think?

@asaid-0 sorry I lost track of this.

These are glob patterns so I'm not sure how safe it is to pass them to path functions. I don't think we have to worry about those edge cases. Trailing slashes though are easier to type, and it's surprising if that breaks the pattern.