Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Lodash with built-in syntax, libraries, and some code #2851

Merged
merged 9 commits into from Oct 4, 2021
Merged

Replace Lodash with built-in syntax, libraries, and some code #2851

merged 9 commits into from Oct 4, 2021
+70 −49

Conversation

live627
Copy link
Contributor

@live627 live627 commented Sep 29, 2021

The recursive cloning methods were retained as their individual npm packages

@novemberborn
Copy link
Member

Thanks @live627! Interestingly, we previously switched to the main lodash package on purpose: #2148

However I think we can remove it entirely, I'm about to push some commits let me know what you think.

@live627
Copy link
Contributor Author

live627 commented Oct 4, 2021

Nifty. I'm just here to remove dependency bloat 🙂

I also have a similar pull request for concordancejs/concordance#78

@novemberborn novemberborn changed the title replace some of lodash with native functions Replace Lodash with built-in syntax, libraries, and some code Oct 4, 2021
@novemberborn novemberborn merged commit d36806a into avajs:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some functions from Lodash can be replaced with native ones
2 participants
@live627 @novemberborn