Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests on latest node 19 #3193

Closed
wants to merge 1 commit into from
Closed

Conversation

flovogt
Copy link
Contributor

@flovogt flovogt commented Apr 13, 2023

We're using ava and run tests against node 19. As of node > 19.5.0 the tests are failing because of

  TypeError [ERR_INVALID_ARG_TYPE]: The "payload" argument must be of type object. Received null

  › file:///home/runner/work/ui5-tooling-extensions/ui5-tooling-extensions/node_modules/mem/dist/index.js:42:27
  › file:///home/runner/work/ui5-tooling-extensions/ui5-tooling-extensions/node_modules/mem/dist/index.js:42:27

See full job details here https://github.com/SAP/ui5-tooling-extensions/actions/runs/4689838073/jobs/8312104201?pr=70

This PR enables ci tests for node 19 to ensure ava runs also smoothly on node 19.

@novemberborn
Copy link
Member

Hadn't noticed we didn't add 19 when it came out. However Node.js 20 is due soon, and we won't be testing against 19 at that point.

I see the tests pass on 19 / Linux though. It's Windows that failed but it could just be flaky. If there is a bug, and you can fix it, then I'm happy to land that along with the CI coverage. Otherwise let's wait for 20.

@flovogt
Copy link
Contributor Author

flovogt commented Apr 19, 2023

@novemberborn Thanks for your response. I've created #3194 which enables v20 in the test pipeline.

@flovogt flovogt closed this Apr 19, 2023
@flovogt flovogt deleted the patch-1 branch April 19, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants