Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade xo to v0.57.0 and lint sources, tests, and examples #3305

Merged
merged 3 commits into from Feb 27, 2024

Conversation

make-github-pseudonymous-again
Copy link
Contributor

Disabled unicorn/prevent-abbreviations because it introduces too many opinionated changes.

Disabled `unicorn/prevent-abbreviations` because it introduces too many
opinionated changes.
@make-github-pseudonymous-again make-github-pseudonymous-again changed the title Upgrade xo to v0.57.0 and lint sources, tests, and examples Upgrade xo to v0.57.0 and lint sources, tests, and examples Feb 10, 2024
@make-github-pseudonymous-again
Copy link
Contributor Author

@novemberborn Any idea why the tests are failing on Linux?

@novemberborn
Copy link
Member

Any idea why the tests are failing on Linux?

The reporter tests are sensitive to line numbers changing, and they're now only run on Linux.

See my commits here: https://github.com/avajs/ava/compare/upgrade-xo-v0.57.0-1?expand=1

(If you could let me push to your branch I can get them into this PR, or you can cherry-pick them.)

@make-github-pseudonymous-again
Copy link
Contributor Author

If you could let me push to your branch I can get them into this PR

@novemberborn Is there a safe way to do that?

@novemberborn
Copy link
Member

If you could let me push to your branch I can get them into this PR

@novemberborn Is there a safe way to do that?

Yes: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@make-github-pseudonymous-again
Copy link
Contributor Author

It does not seem to be available on this PR for some reason 🤔

@novemberborn
Copy link
Member

Can you cherry-pick my commits, or merge my branch from avajs/ava into yours?

@make-github-pseudonymous-again
Copy link
Contributor Author

Can you cherry-pick my commits, or merge my branch from avajs/ava into yours?

@novemberborn Done.

@novemberborn novemberborn merged commit 1d62caf into avajs:main Feb 27, 2024
16 checks passed
@novemberborn
Copy link
Member

Thanks @make-github-pseudonymous-again!

@make-github-pseudonymous-again make-github-pseudonymous-again deleted the upgrade-xo-v0.57.0-1 branch February 28, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants