Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ESLint 7 #310

Merged
merged 4 commits into from Aug 16, 2020
Merged

Upgrade to ESLint 7 #310

merged 4 commits into from Aug 16, 2020

Conversation

novemberborn
Copy link
Member

Drop ESLint 6 support.

I, uhm, kinda brute forced things so that the tests would pass. I don't actually understand what I've changed.

Remove js-combinatorics which has stopped supporting CJS. It's not necessary to test this number of permutations, some of which are not even supported by AVA.
Copy link
Member

@sindresorhus sindresorhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. ruleId was never any useful anyway as we only run the given rule in the tests.

@sindresorhus
Copy link
Member

We did a similar migration here too: sindresorhus/eslint-plugin-unicorn#577

@novemberborn
Copy link
Member Author

Thanks @sindresorhus

@novemberborn novemberborn merged commit dcba649 into master Aug 16, 2020
@novemberborn novemberborn deleted the bump-deps branch August 16, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants