Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional_plugins/spawner_remote: add missing manifest to include VERSION #5839

Merged
merged 3 commits into from
Dec 23, 2023

Conversation

clebergnu
Copy link
Contributor

Without this, building packages (such as wheels) will fail for the plugin.

Without this, building packages (such as wheels) will fail for the
plugin.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
@clebergnu clebergnu self-assigned this Dec 22, 2023
@mr-avocado
Copy link

mr-avocado bot commented Dec 22, 2023

Dear contributor,
Avocado is currently under sprint #103, which is due to release an LTS (Long Term Stability) release.
Please avoid merging changes that do not fall into these categories:

  • Bug fixes
  • Usability Improvements
  • Documentation updates

As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality,
but changes to the existing APIs (including interface and behavior) should be avoided.
These kind of changes should wait until sprint #104.

@clebergnu
Copy link
Contributor Author

For the record, it's unfortunately a silent failure and can be seen here:

2023-12-22T14:57:52.8774519Z removing 'avocado-framework-plugin-spawner-remote-102.0' (and everything under it)
2023-12-22T14:57:52.9196845Z * Building wheel from sdist
2023-12-22T14:57:52.9197541Z * Creating venv isolated environment...
2023-12-22T14:57:56.4029440Z * Installing packages in isolated environment... (setuptools >= 40.8.0, wheel)
2023-12-22T14:57:57.9448231Z * Getting build dependencies for wheel...
2023-12-22T14:57:58.0480785Z Traceback (most recent call last):
2023-12-22T14:57:58.0482986Z   File "/home/runner/.local/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
2023-12-22T14:57:58.0484631Z     main()
2023-12-22T14:57:58.0486808Z   File "/home/runner/.local/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 335, in main
2023-12-22T14:57:58.0488759Z     json_out['return_val'] = hook(**hook_input['kwargs'])
2023-12-22T14:57:58.0489683Z                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2023-12-22T14:57:58.0491434Z   File "/home/runner/.local/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
2023-12-22T14:57:58.0492931Z     return hook(config_settings)
2023-12-22T14:57:58.0493450Z            ^^^^^^^^^^^^^^^^^^^^^
2023-12-22T14:57:58.0495832Z   File "/tmp/build-env-51haf5y4/lib/python3.12/site-packages/setuptools/build_meta.py", line 325, in get_requires_for_build_wheel
2023-12-22T14:57:58.0497622Z     return self._get_build_requires(config_settings, requirements=['wheel'])
2023-12-22T14:57:58.0498555Z            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2023-12-22T14:57:58.0500243Z   File "/tmp/build-env-51haf5y4/lib/python3.12/site-packages/setuptools/build_meta.py", line 295, in _get_build_requires
2023-12-22T14:57:58.0501429Z     self.run_setup()
2023-12-22T14:57:58.0502662Z   File "/tmp/build-env-51haf5y4/lib/python3.12/site-packages/setuptools/build_meta.py", line 480, in run_setup
2023-12-22T14:57:58.0504180Z     super(_BuildMetaLegacyBackend, self).run_setup(setup_script=setup_script)
2023-12-22T14:57:58.0505268Z   File "/tmp/build-env-51haf5y4/lib/python3.12/site-packages/setuptools/build_meta.py", line 311, in run_setup
2023-12-22T14:57:58.0506135Z     exec(code, locals())
2023-12-22T14:57:58.0506440Z   File "<string>", line 29, in <module>
2023-12-22T14:57:58.0507349Z FileNotFoundError: [Errno 2] No such file or directory: '/tmp/build-via-sdist-y4elmtsk/avocado-framework-plugin-spawner-remote-102.0/VERSION'

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@richtja richtja merged commit 09fd209 into avocado-framework:master Dec 23, 2023
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants