Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe with dependencies fix #5925

Merged
merged 1 commit into from
May 3, 2024

Conversation

richtja
Copy link
Contributor

@richtja richtja commented May 2, 2024

This commit moves dependency serialization to Dependency class from safeloader to runnable. This will enable the use of dependencies in recipe files.

Reference: #5918

@richtja richtja added the bug label May 2, 2024
@richtja richtja requested a review from clebergnu May 2, 2024 11:43
@richtja richtja self-assigned this May 2, 2024
@mr-avocado
Copy link

mr-avocado bot commented May 2, 2024

Dear contributor,
Avocado is currently at the end of sprint #105, therefore we are in feature freeze state.
Please avoid merging changes that do not fall into these categories:

  • Bug fixes
  • Documentation updates

The feature freeze will be active until the release planned on 05/06/2024.

@richtja richtja force-pushed the dependency_recipe_fix branch 2 times, most recently from 2d4ffe1 to 2ea12ed Compare May 2, 2024 13:17
Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @richtja, just have a question/style suggestion, but overall, LGTM. Thanks!

selftests/functional/serial/requirements.py Outdated Show resolved Hide resolved
This commit moves dependency serialization to Dependency class from
safeloader to runnable. This will enable the use of dependencies in
recipe files.

Reference: avocado-framework#5918
Signed-off-by: Jan Richter <jarichte@redhat.com>
@richtja richtja requested a review from clebergnu May 3, 2024 14:45
@clebergnu clebergnu merged commit d72a7ae into avocado-framework:master May 3, 2024
60 checks passed
@richtja richtja deleted the dependency_recipe_fix branch May 3, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done 105
Development

Successfully merging this pull request may close these issues.

None yet

2 participants