Add couple utility in disk utility #5928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear contributor,
The feature freeze will be active until the release planned on 05/06/2024. |
PraveenPenguin
changed the title
PraveenPenguin
force-pushed
the
add_disk
branch
3 times, most recently
from
00f5729
to
f38bb3b
Compare
|
Hi @PraveenPenguin, alongside the static check and codespell it LGTM. Can you please make your code align with static checks and add |
PraveenPenguin
force-pushed
the
add_disk
branch
4 times, most recently
from
fe92ea2
to
595078c
Compare
added a utility which Returns io scheduler available for the IO Device Signed-off-by: Praveen K Pandey <praveen@linux.vnet.ibm.com>
PraveenPenguin
force-pushed
the
add_disk
branch
2 times, most recently
from
3d4df0f
to
d22bae0
Compare
Added utility in disk library help to Set io scheduler to a device Signed-off-by: Praveen K Pandey <praveen@linux.vnet.ibm.com>
|
@richtja resolved CI issue can you please review |
richtja
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1- added a utility which Returns io scheduler available for the IO Device
2-Added utility in disk library help to Set io scheduler to a device