Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin @babel/core dep in test targets #377

Closed
wants to merge 1 commit into from
Closed

Conversation

alharris-at
Copy link
Contributor

Issue #, if available:
aws-amplify/amplify-ui#1242

Description of changes:
pin deps until this issue is resolved upstream.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alharris-at alharris-at requested a review from a team February 3, 2022 00:38
@codecov-commenter
Copy link

Codecov Report

Merging #377 (7eacc94) into main (9624d5d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files          36       36           
  Lines        1244     1244           
  Branches      278      278           
=======================================
  Hits         1115     1115           
  Misses        126      126           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9624d5d...7eacc94. Read the comment docs.

@alharris-at
Copy link
Contributor Author

It looks like Babel has already fixed upstream. Running canaries now to confirm if this change is needed.

@alharris-at
Copy link
Contributor Author

Yeah, canary succeeds now with the babel fix. Closing this PR.

@alharris-at alharris-at closed this Feb 3, 2022
@dpilch dpilch deleted the pin-babel-core branch February 7, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants