Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): add E2E tests for DataStore docs examples #11031

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

david-mcafee
Copy link
Member

@david-mcafee david-mcafee commented Feb 28, 2023

Description of changes

feat(data): add E2E tests for DataStore docs examples

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@david-mcafee david-mcafee marked this pull request as ready for review February 28, 2023 03:29
@david-mcafee david-mcafee requested review from a team as code owners February 28, 2023 03:29
@david-mcafee david-mcafee requested a review from a team February 28, 2023 03:29
@codecov-commenter
Copy link

Codecov Report

Merging #11031 (d055abb) into main (8f6dd70) will decrease coverage by 3.76%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main   #11031      +/-   ##
==========================================
- Coverage   85.65%   81.90%   -3.76%     
==========================================
  Files         196      194       -2     
  Lines       18261    19373    +1112     
  Branches     3892     4176     +284     
==========================================
+ Hits        15642    15868     +226     
- Misses       2543     3216     +673     
- Partials       76      289     +213     
Impacted Files Coverage Δ
...ackages/pubsub/src/Providers/AWSAppSyncProvider.ts 15.38% <0.00%> (-52.75%) ⬇️
packages/datastore/src/predicates/index.ts 78.86% <0.00%> (-17.08%) ⬇️
packages/amazon-cognito-identity-js/src/Client.js 50.48% <0.00%> (-1.52%) ⬇️
...ackages/pubsub/src/Providers/MqttOverWSProvider.ts 91.53% <0.00%> (-1.06%) ⬇️
packages/pubsub/src/PubSub.ts 92.42% <0.00%> (-0.64%) ⬇️
...ages/amazon-cognito-identity-js/src/CognitoUser.js 79.06% <0.00%> (-0.12%) ⬇️
packages/datastore/__tests__/commonAdapterTests.ts 98.26% <0.00%> (-0.07%) ⬇️
packages/datastore/src/types.ts 86.47% <0.00%> (ø)
packages/api-graphql/src/GraphQLAPI.ts 88.48% <0.00%> (ø)
packages/storage/src/common/StorageConstants.ts 85.71% <0.00%> (ø)
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@manueliglesias manueliglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants