-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Run ts coverage check with test #11047
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #11047 +/- ##
=======================================
Coverage 82.15% 82.15%
=======================================
Files 193 193
Lines 19511 19511
Branches 4231 4231
=======================================
Hits 16029 16029
Misses 3194 3194
Partials 288 288
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thank you for putting this together and fixing the non running tests.
Maybe it is out of the scope for this PR, but I'm wondering if there is the need to update the current threshold for some packages as TS improvements have been applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm thanks!
Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
Description of changes
Enable ts coverage check and reporting with each
npm run test
execution.This is already enabled for several categories, but this change turns it on for the remaining categories.
Description of how you validated changes
Verified that
npm run test
includes a coverage check for each category.Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.