Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run ts coverage check with test #11047

Merged
merged 10 commits into from
Mar 8, 2023
Merged

Conversation

stocaaro
Copy link
Contributor

@stocaaro stocaaro commented Mar 6, 2023

Description of changes

Enable ts coverage check and reporting with each npm run test execution.

This is already enabled for several categories, but this change turns it on for the remaining categories.

Description of how you validated changes

Verified that npm run test includes a coverage check for each category.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stocaaro stocaaro requested review from a team as code owners March 6, 2023 20:40
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #11047 (86c9b57) into main (2c5b5a7) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main   #11047   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files         193      193           
  Lines       19511    19511           
  Branches     4231     4231           
=======================================
  Hits        16029    16029           
  Misses       3194     3194           
  Partials      288      288           
Impacted Files Coverage Δ
packages/predictions/src/types/Predictions.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

israx
israx previously approved these changes Mar 6, 2023
Copy link
Contributor

@israx israx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you for putting this together and fixing the non running tests.

Maybe it is out of the scope for this PR, but I'm wondering if there is the need to update the current threshold for some packages as TS improvements have been applied.

israx
israx previously approved these changes Mar 6, 2023
svidgen
svidgen previously approved these changes Mar 6, 2023
@stocaaro stocaaro dismissed stale reviews from svidgen and israx via 7ad055c March 7, 2023 18:15
jimblanc
jimblanc previously approved these changes Mar 7, 2023
packages/pushnotification/package.json Outdated Show resolved Hide resolved
cshfang
cshfang previously approved these changes Mar 7, 2023
Copy link
Contributor

@cshfang cshfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks!

stocaaro and others added 2 commits March 7, 2023 12:33
@stocaaro stocaaro dismissed stale reviews from cshfang and jimblanc via 4d5ad7e March 7, 2023 18:50
@stocaaro stocaaro merged commit 430bedf into aws-amplify:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants