Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geo): support Language options in map searches #11178

Merged
merged 31 commits into from
Dec 20, 2023

Conversation

roelvandenbrand
Copy link
Contributor

@roelvandenbrand roelvandenbrand commented Apr 3, 2023

Description of changes

Added a optional language attribute to the Geo search mapper to be able to receive the response from AWS Location services in a desired language.

Issue #, if available

#11177

Description of how you validated changes

Added the optional language attribute to an existing test and verified it is in the request to the Location provider on AWS.
Ran "yarn test"
Checked failed tests, there were some on Cognito where nothing changed. No error in the Geo tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@roelvandenbrand roelvandenbrand requested review from a team as code owners April 3, 2023 11:49
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Merging #11178 (7f9f1a1) into main (3e5e6f9) will increase coverage by 0.14%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main   #11178      +/-   ##
==========================================
+ Coverage   83.23%   83.38%   +0.14%     
==========================================
  Files         274      294      +20     
  Lines       20523    20862     +339     
  Branches     4436     4489      +53     
==========================================
+ Hits        17083    17395     +312     
- Misses       3152     3180      +28     
+ Partials      288      287       -1     

see 56 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roelvandenbrand
Copy link
Contributor Author

Not sure which documentation to change. Much of it looks generated. And because of the line-numbers in the referencing docs some of it might need to be regenerate.

@tannerabread tannerabread added first-time-contributor The contribution is the first for this user in the repo external-contributor labels Apr 12, 2023
@stocaaro stocaaro self-assigned this Apr 18, 2023
AllanZhengYP
AllanZhengYP previously approved these changes Apr 18, 2023
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Confirmed the new parameter is supported by underlying AWS SDK client. We just need to review the public interface change on Amplify library side.

.gitignore Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think changes in this file is necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I reverted to the previous version of that file.

@cwomack cwomack requested a review from AllanZhengYP May 4, 2023 15:01
@roelvandenbrand
Copy link
Contributor Author

I keep updating the branch, but is there something I should still do on the PR?

@stocaaro stocaaro removed their assignment Aug 16, 2023
Copy link
Contributor

@thaddmt thaddmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cwomack cwomack requested review from cwomack and a team December 20, 2023 17:48
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AllanZhengYP AllanZhengYP changed the title Geo/feat/11177 language feat(geo): support Language options in map searches Dec 20, 2023
@AllanZhengYP AllanZhengYP merged commit 1477488 into aws-amplify:main Dec 20, 2023
30 checks passed
@cwomack
Copy link
Contributor

cwomack commented Dec 21, 2023

@roelvandenbrand, thank you for submitting this PR! We've gotten it merged and appreciate your patience and contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor first-time-contributor The contribution is the first for this user in the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants