fix(client): correct clock skew from any response

[AllanZhengYP]

Description of changes

Currently only in Pinpoint client, we use signing middleware to keep track of clock offset between local clock and server clock. The current implementation incorrectly assumes the error responses are already parsed to JavaScript errors and thrown from next handler. However this is not true for signing middleware. Because it's applied always after the retry middleware, the HTTP responses regardless of status code are returned from the next handler.

The signing middleware after this change, maintain the offset for both successful or fail HTTP response.

Description of how you validated changes

Manually validated.

Checklist

• PR description included
• yarn test passes
• Tests are changed or added
• Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov-commenter]

Codecov Report

Merging #11503 (14ec078) into main (2e1e1f5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main   #11503      +/-   ##
==========================================
- Coverage   83.24%   83.24%   -0.01%     
==========================================
  Files         274      274              
  Lines       20565    20559       -6     
  Branches     4447     4444       -3     
==========================================
- Hits        17120    17114       -6     
  Misses       3157     3157              
  Partials      288      288              

Impacted Files	Coverage Δ
...e/src/clients/middleware/retry/isClockSkewError.ts	100.00% <ø> (ø)
...rc/clients/middleware/retry/defaultRetryDecider.ts	100.00% <100.00%> (ø)
.../core/src/clients/middleware/signing/middleware.ts	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[manueliglesias]

LGTM

[elorzafe]

Looks good, thanks @AllanZhengYP 🏅