fix: only register auth urlListener from InternalAuth instance #11810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erinleigh90
changed the title
kvramyasri7
approved these changes
Aug 16, 2023
stocaaro
approved these changes
Aug 16, 2023
4 tasks
kvramyasri7
pushed a commit
to kvramyasri7/amplify-js
that referenced
this pull request
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Prevents duplication of OAuth token callback due to urlListener registered in Auth instance and InternalAuth instance. Added a check to only register if moduleName is InternalAuth.
Issue #, if available
#11808
Description of how you validated changes
Tested using yarn linking in a sample app
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.